Highlight colors are all the same

[mrtorrent]

Hi, thanks for the excellent job porting this theme to Netbeans. One small issue I noticed is that the colors for highlighting the current line, usages of the current variable, and selected text are all the same, so there's no way to distinguish them.

[fentie]

I'll see what I can do about this. From what I gather based on the original scheme, the current line highlighting should be base 2/base 02. I have some values for selected text too, I just need to fish them out. I should be able to look at this in the next day or three at home. Is this an issue in light, dark, or both?

[mrtorrent]

I use the dark scheme, but I'll have a look at the light one tomorrow to see if it's the same. On Sep 27, 2011 8:15 PM, "Brian Fenton" < reply@reply.github.com> wrote:

I'll see what I can do about this. From what I gather based on the original scheme, the current line highlighting should be base 2/base 02. I have some values for selected text too, I just need to fish them out. I should be able to look at this in the next day or three at home. Is this an issue in light, dark, or both?

Reply to this email directly or view it on GitHub:

https://github.com/fentie/netbeans-colors-solarized/issues/7#issuecomment-2215023

[mrtorrent]

It appears that the light scheme is slightly different: the current line color, mark occurrences color, and search results color are the same as each other, but the selected text color is different

On Tue, Sep 27, 2011 at 8:17 PM, Miquel Rodríguez Telep mrtorrent@gmail.com wrote:

I use the dark scheme, but I'll have a look at the light one tomorrow to see if it's the same.

On Sep 27, 2011 8:15 PM, "Brian Fenton" reply@reply.github.com wrote:

I'll see what I can do about this. From what I gather based on the original scheme, the current line highlighting should be base 2/base 02. I have some values for selected text too, I just need to fish them out. I should be able to look at this in the next day or three at home. Is this an issue in light, dark, or both?

Reply to this email directly or view it on GitHub:

https://github.com/fentie/netbeans-colors-solarized/issues/7#issuecomment-2215023

[fentie]

Just pushed a fix for Dark selected text. I'll have to figure out what to use for mark occurrences... there don't seem to be any real guidelines in the Solarized demo pages for what color that should be.

Still working on Light too, hopefully tomorrow

[jerclarke]

I'm really enjoying blue background with darkest foreground for mark occurrences. It's kind of intense, but I think that makes sense for the feature. Yellow makes even more sense, but I found it a bit blinding at least on the dark theme. I bet the light theme could tolerate yellow.

Looking at the screenshots on the solarized site it seems to me that at least for PHP the netbeans version lacks color. There a lot of the highlights that just dont' show up at all for me in my code. I've been sprucing up my version, are you interested in alternate organizations of the colors?

[fentie]

Hey, thanks for the comment. I tried to implement the color scheme as best I could, but the color theming options in NetBeans aren't nearly as robust as they are in TextMate, Vim, or other editors. I'm pretty comfortable saying somewhere between 65-90% of the text sections that are able to have a specified color have one assigned.

I wouldn't be opposed to alternate color sets. Can you set up some screenshots, or use the color names on the Solarized site (like base02) so I can get a better idea of what you're talking about? I'm also happy to look at pull requests too, if you want to make your proposed changes in a fork.

[fentie]

I believe the original issue to be resolved, so I'm closing this.