Added build_simple script and Dockerfile for building inside docker-container

fenugrec / freediag

OBD2 scantool

GNU General Public License v3.0

338 stars 75 forks source link

Added build_simple script and Dockerfile for building inside docker-container #57

Closed sea-kg closed 4 years ago

sea-kg commented 4 years ago

build_simple.sh - file with cmake commands and comment with requirements
Dockerfile - for building sources inside docker-container (prepared building enviroment)

fenugrec commented 4 years ago

Interesting PR, thanks for submitting. Is the build_simple.sh required for the docker or is it just an example ?

sea-kg commented 4 years ago

Build simple it's just helper script with 4 commands (no docker):

mkdir -p tmp # folder where will be build all files
cd tmp # will be building there
cmake .. # first run cmake for configuring
make # and make project

fenugrec commented 4 years ago

ok. And in build_simple.sh , could you make these few changes:

use 'build/' instead of tmp/, (same in .gitignore), it's a bit more common I think.
add in the comments to refer to doc/build_system.txt for more information

Thanks

sea-kg commented 4 years ago

Ok.

Maybe better add HOW-TO-BUILD.md in a root of project ?

fenugrec commented 4 years ago

Maybe better add HOW-TO-BUILD.md in a root of project ?

No, I don't think I want another file. I may add a paragraph in the README that mentions build-simple.sh, but it already references doc/build_system.txt which has detailed information. I don't want compiling instructions in 3 different places...

sea-kg commented 4 years ago

Ok. I m understood.