Compile source tree with Visual Studio 2017 (toolset v141, v141_xp)

[cfehse]

Scope

The scope of this PR is to make the source tree configure/compile with Visual Studio 2017 - especially the toolsets v141, v141_xp to be able to create Windows XP binaries with a Microsoft compiler. This MSVC version 19.1 compiler provide the required c99 support to build the sources. Additional c11 features may break this compiler version (like the Embarcadero compiler) but because the changes were minor I find it worth to add the support to the source tree,

What has changed?

Source Files:

CMakeLists.txt scantool/diag.h

• Changed the checks for MSVC_VERSION and _MSVC_VERSION to < 1910 (Visual Studio 2017) to support the compiler from toolset v141, v141_xp.

doc/build_system.txt

• Added build information regarding Visual Studio 2017.
• Added detailed information to build Windows XP 32 bit binaries with Visual Studio 2019 and toolset v141_xp (because it is not that straight forward).

scantool\freediag.rc scantool\diag_test.rc

• Removed the not needed include of <winuser.h> which caused resource compiler errors with the v141 toolsets.

scantool/diag_l0_sim.c

• Changed the declaration of the sim_send() function to match the implementation (4. parameter was const in the implementation but not in the declaration). This mismatch was reported as a warning by the v141 toolset compiler. I wonder why no other compiler configuration thought this was worth a warning at all.

Tested Environments:

All changes where tested using these environments:

Cppcheck:

• Cppcheck 2.3 on Windows
• Cppcheck 1.86 on Debian (Limited tests because the command line version requires version 1.90 or later to be able to use the Cppcheck GUI project file format. Currently my Debian 10 systems have no Cppcheck 1.90 or better prebuild packages available)

Compiler/Build Environment:

• Visual Studio 2019 (x86/x64) (integrated cmake and cmake 3.19.3)
• Visual Studio 2019 (x86 toolset v141, v141_xp) (cmake 3.14.0 and higher)
• Visual Studio Code on Windows (MinGW, MinGW64, BCC, MSVC) (cmake 3.10.0 and higher)
• Visual Studio Code remote on WSL (cmake 3.13.4 default installation Debian)
• Debian (cmake 3.13.4 default installation Debian)

Perhaps you like the changes and accept this merge request.

Thanks!

@fenugrec

[fenugrec]

* Changed the declaration of the `sim_send()` function to match the implementation

! Indeed, how did I miss that for so long ? none of our tools (gcc since v7, cppcheck, etc) signaled that inconsistency... and I have -Wall -Wextra etc. since forever. Weird.

The rest also looks good, will merge "soon"

[cfehse]

none of our tools (gcc since v7, cppcheck, etc) signaled that inconsistency...

And our for the time being last compiler coming in the next PR (clang on Linux) did not find this declaration mismatch worth mentioning either.

[fenugrec]

merged, thanks !