search

fenugrec / nisprog

nisprog Nissan ECU reflashing tool
GNU General Public License v3.0
80 stars 17 forks source link

VIN Writing Support #25

Closed Pytrex closed 1 year ago

Pytrex commented 1 year ago

Adds core logic for VIN writing support.

Usage: writevin VIN is case insensitive.

fenugrec commented 1 year ago

cool that was fast. Told you it would be simple !

Proper error handling should be just aborting the command - most typical cause I expect would be losing connection (e.g. physical disconnect etc). And if it's just the ECU refusing for unknown reasons, I'd rather not force retrying; leave that decision for the user.

Pytrex commented 1 year ago

cool that was fast. Told you it would be simple !

True! The template code you showed definitely helped as well!

Proper error handling should be just aborting the command - most typical cause I expect would be losing connection (e.g. physical disconnect etc). And if it's just the ECU refusing for unknown reasons, I'd rather not force retrying; leave that decision for the user.

Right. It's not exactly a critical command that can't afford to be dropped lol

fenugrec commented 1 year ago

split the commit and added error handling on this branch https://github.com/fenugrec/nisprog/tree/wvin

having trouble compiling for win* due to some unrelated cppcheck errors, need to look at that closer before making a new release

fenugrec commented 1 year ago

Merged, thanks ! may fail to build if certain versions of cppcheck are present (problem is a too-strict setting in upstream freediag build sys), fix pending