search

feos-org / feos

FeOs - A Framework for Equations of State and Classical Density Functional Theory
Other
115 stars 22 forks source link

Fix the sign of vector weighted densities in cartesian and cylindrical geometry #120

Closed prehner closed 1 year ago

prehner commented 1 year ago

With this change vector weighted densities will have the correct signs in all geometries.

While this is an important validation of the correctness of the transforms in general, the sign of vector weighted densities had no effect on results as they always appear in dot products in the calculation of Helmholtz energies, which cancel out their sign.

Shout out to @RolfStierle and @oivindwi.

prehner commented 1 year ago

At the moment the calculation is excruciatingly hard to comprehend due to some shortcuts/simplifications that were applied without further explanations. It should be explained in the theory guide.