ferPrieto / steps-app-gallery-deploy

This is the Bitrise step to deploy a build in AppGallery Connect
MIT License
10 stars 7 forks source link

Fixes the query parameters for the compile/status request #27

Closed albertovecina closed 12 months ago

albertovecina commented 1 year ago

Context: We are experiencing a failure during the deploy process. The submission is failing even though the application update is created.

`+ SUBMISSION_STATUS=null

Checking the code, we noticed that the status api request was failing so the step does not perform the app submission.

SOLUTION

Testing the api using Postman we are getting this message: { "message": "Parameter is not valid for operation [AppGalleryConnectPublishService.publish-services.getPackageCompileStatus]. Parameter is [pkgIds]. Processor is [query]." }

So as the huawei documentation points out (https://developer.huawei.com/consumer/en/doc/development/AppGallery-connect-References/agcapi-query-aabfile-0000001111685206), the proper name for the second query paremeter in the status method is pkgIds. Tested using postman, the change works fine.

{
    "ret": {
        "code": 0,
        "msg": "success"
    },
    "pkgStateList": [
        {
            "pkgId": "XXXXXXXXXXXX",
            "aabCompileStatus": 0,
            "successStatus": 0
        }
    ]
}
ferPrieto commented 1 year ago

Hey Alberto, thanks for the PR. Let me double check with something already merged and not rolled out in production yet. I'll keep you posted

albertovecina commented 1 year ago

Any news about this? Is there anything we can do on our side?

Thanks

ferPrieto commented 1 year ago

Hey Alberto,

I'm putting out a PR today. Last week I raised one but there was a conflict with the old Step directory. Will keep you posted.

Best, Fernando

On Mon, 25 Sept 2023 at 10:21, Alberto Vecina Sánchez < @.***> wrote:

Any news about this? Is there anything we can do on our side?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/ferPrieto/steps-app-gallery-deploy/pull/27#issuecomment-1733254738, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH2QPFY7SB6QMGWHLFKPWLX4FEJ3ANCNFSM6AAAAAA3452YOY . You are receiving this because you commented.Message ID: @.***>

ferPrieto commented 1 year ago

Hey Alberto,

I put out a PR https://github.com/bitrise-io/bitrise-steplib/pull/4004 yesterday again (the one raised last week had a project ID issue). It should be reviewed and merged soon. I'll keep you posted.

Best, Fernando

On Tue, 26 Sept 2023 at 09:36, Fernando Prieto @.***> wrote:

Hey Alberto,

I'm putting out a PR today. Last week I raised one but there was a conflict with the old Step directory. Will keep you posted.

Best, Fernando

On Mon, 25 Sept 2023 at 10:21, Alberto Vecina Sánchez < @.***> wrote:

Any news about this? Is there anything we can do on our side?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/ferPrieto/steps-app-gallery-deploy/pull/27#issuecomment-1733254738, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH2QPFY7SB6QMGWHLFKPWLX4FEJ3ANCNFSM6AAAAAA3452YOY . You are receiving this because you commented.Message ID: @.***>

ferPrieto commented 1 year ago

@albertovecina would you mind trying with the latest version just merged and let me know if that fixes the issue? Otherwise I can look at your suggestion

albertovecina commented 1 year ago

Hi @ferPrieto. We will try to deploy a release today. I will keep you posted. Thanks for your support.

albertovecina commented 1 year ago

Hi @ferPrieto. It's working in the last version, thanks!

albertovecina commented 12 months ago

It was good last friday, but today it failed again both times using the 1.5.6 version. Just the submission is failing. Log of the success:

`Submitting the app directly... ++ curl --silent -X POST 'https://connect-api.cloud.huawei.com/api/publish/v2/app-submit?appid=[REDACTED]' -H 'Authorization: Bearer XXXXX' -H 'client_id: [REDACTED]'

Error log:

`Submitting the app directly... ++ curl --silent -X POST 'https://connect-api.cloud.huawei.com/api/publish/v2/app-submit?appid=[REDACTED]' -H 'Authorization: XXXXXXXX' -H 'client_id: [REDACTED]'

ferPrieto commented 12 months ago

It went wrong last friday, but today it failed again both times using the 1.5.6 version. Just the submission is failing. Log of the success I guess you were meant to say it worked last Friday?

I will have a look later and potentially will create a new version with the proposed changes. Thank you again 😄

albertovecina commented 12 months ago

It went wrong last friday, but today it failed again both times using the 1.5.6 version. Just the submission is failing. Log of the success I guess you were meant to say it worked last Friday?

I will have a look later and potentially will create a new version with the proposed changes. Thank you again 😄

Great, thanks!

ferPrieto commented 12 months ago

@albertovecina the PR is raised on the Bitrise Steplib repo. I'll keep you posted about when it gets merged

ferPrieto commented 11 months ago

@albertovecina the PR is already merged. Please let me know if everything is sorted now

albertovecina commented 11 months ago

Still having this message:

printf 'Submission Status null' Submission Status null+ i=0

Using 1.5.7 versión. I don't have any suggestion by now.