search

ferd / dlhttpc

dispcount-based lhttpc fork for massive amounts of requests to limited endpoints
Other
36 stars 17 forks source link

Add option to retry resource checkout #7

Closed loucash closed 9 years ago

loucash commented 9 years ago

@ferd Hey, we are experiencing a lot of checkout misses, even though there are resources available. So we were thinking about a possibility to increase our chances for checkout a resource by retrying. I added an option checkout_retry. What do you think about it? Is it viable for dlhttpc?

aerosol commented 9 years ago

:+1:

ferd commented 9 years ago

I'm for this functionality, but it looks like there was a major oversight in the implementation.

loucash commented 9 years ago

Ugh, sorry, my patch is buggy. Let me fix it. What do you think about idea itself?

On Fri, Nov 21, 2014 at 3:29 PM, Fred Hebert notifications@github.com wrote:

I'm for this functionality, but it looks like there was a major oversight in the implementation.

Reply to this email directly or view it on GitHub https://github.com/ferd/dlhttpc/pull/7#issuecomment-63985622.

ferd commented 9 years ago

I'm for this functionality. It's something worth doing in some cases when you're not willing to lose data. I'm guessing at some point someone will want to add some timer in between attempts, but given the nature of dispcount and dlhttpc and the kind of apps it's used in, that should be fine as is.

loucash commented 9 years ago

I fixed a leak, you have spotted in c597be73d81cde4ffc716b4edd00fb0922d65e51. Thanks!

loucash commented 9 years ago

Fixes are in: afdd28d602dd365d9afd9618b99187876a5598d5 :nail_care: