search

ferdium / ferdium-app

All your services in one place, built by the community
https://ferdium.org
Apache License 2.0
2.78k stars 168 forks source link

WhatsApp notifications getting through the Focus/DND/Privacy mode being on (both Mac and Windows) #1047

Open hnykda opened 1 year ago

hnykda commented 1 year ago

Avoid duplicates

Ferdium Version

6.2.4

What Operating System are you using?

macOS

Operating System Version

13.2.1

What arch are you using?

x64

Last Known Working Ferdium version

No response

Expected Behavior

When Mac's "Focus" feature is on, I should not hear any sound notifications when I receive a new WhatsApp message.

Actual Behavior

I do hear a message.

Steps to reproduce

  1. sign in into WhatsApp in Ferdium
  2. switch on the focus mode
  3. wait for a message to come
  4. listen to the sound

Debug link

No response

Screenshots

No response

Additional information

Note that this happens with the official WhatsApp application as well for some reason. I think it relates to https://github.com/ferdium/ferdium-app/issues/798 and https://github.com/felixrieseberg/macos-notification-state/pull/38, but I am unsure. Note this is Whatsapp specific, and it's apparently fairly common issue.

Gaibhne commented 1 year ago

This same issue exists in the latest Windows build of Ferdium. Despite notifications being disabled both in the server and globally, as well as having the privacy option set to not display notification contents, WhatsApp notifications always get displayed, including their texts, which essentially means I had to stop using WhatsApp at work completely, because I can't have explicit messages from my girlfriend pop up while the boss is looking over my shoulder 😂

I would recommend adjusting the issue title to be more inclusive, as it doesn't look like this is a Mac specific issue.

leoheck commented 1 year ago

I would also want to disable notification sounds. They are annoying and I could not find a way to mute them.

hnykda commented 1 year ago

Update! I don't experience the notifications going through on 6.2.6 nightly.

Version: 6.2.6-nightly.4
Server: Ferdium Server
Electron: 23.1.3
Chrome: 110.0.5481.179
Node.js: 18.12.1
Platform: macOS Unknown
Arch: arm64
Build date: Sun Mar 12 2023 02:03:36 GMT+0100 (Central European Standard Time)
Git SHA: 35206504
Git branch: nightly
hnykda commented 1 year ago

Therefore, I am tempted to close it. Will see if it happens again, but if not, this can be closed in ~30 days

Gaibhne commented 1 year ago

@hnykda I vote to reopen this; in version 6.2.6-beta.1, which falls between 6.2.6-nightly.8, 6.2.6-nightly.9, this bug is still present (and also affecting IRCCloud).

hnykda commented 1 year ago

Agree, happens to me still.

JKHSDTV commented 3 months ago

@Alphrag I would ask that this issue be reopened. The linked fix clearly only applies to MacOS, so it seems very unlikely that it would fix a Windows bug.

Alphrag commented 3 months ago

Hey @JKHSDTV I admit I only considered this issue related to macos because no details were given relatively to how the Windows privacy mode behaves. So we would need more information on that as well. As for the potential fix on macos, it caused an other problem so was reverted anyway, making this issue probably still of consideration.

hnykda commented 3 months ago

I am indeed still getting notifications through Focus mode on MacOS