HDR Screenshots unusable

ferdium / ferdium-app

All your services in one place, built by the community

https://ferdium.org

Apache License 2.0

2.95k stars 176 forks source link

HDR Screenshots unusable #1112

Open ysoudy opened 1 year ago

ysoudy commented 1 year ago

Avoid duplicates

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issues tracker for a bug report similar to mine, in vain

Ferdium Version

6.2.6

What Operating System are you using?

Windows

Operating System Version

Windows 11

What arch are you using?

x64

Last Known Working Ferdium version

No response

Expected Behavior

The expected behavior would be for Ferdium to accurately capture and display screenshots taken on HDR displays, without excessive brightness or color distortion, making them usable for their intended purposes.

Actual Behavior

The screenshots taken on Ferdium with an HDR display are overly flashy. As a result, they are unusable. Ferdium should be updated to support this type of display, which is becoming increasingly common.

Steps to reproduce

Enable HDR on windows settings
Take a screenshot on ferdium

Debug link

No response

Screenshots

Additional information

No response

victorbnl commented 1 year ago

Are you sure it is not your operating system’s fault? What is the behaviour with other applications? And what happens if you put another application and Ferdium on the same screenshot? I’m struggling to see how Ferdium could be the issue here, but it might be for lack of knowledge about the HDR technology.

Also, how does it behave with Chrome/Chromium, and other Electron applications?

ysoudy commented 1 year ago

I have no issue in Chrome or other application : screenshots are OK. There is only the issue with Ferdium :/

jpdoherty commented 1 year ago

In Chrome, this issue is fixed by setting the force-color-profile flag to sRGB. My understanding is that is can be fixed in Electron with something like app.commandLine.appendSwitch('force-color-profile', 'srgb');.

ysoudy commented 1 year ago

In Chrome, this issue is fixed by setting the force-color-profile flag to sRGB. My understanding is that is can be fixed in Electron with something like app.commandLine.appendSwitch('force-color-profile', 'srgb');.

Thx.... Finaly someone has a solution !

mcmxcdev commented 1 year ago

Hey @ysoudy, do you still encounter this problem?

If you do, I can take a look at implementing the solution mentioned by @jpdoherty

jpdoherty commented 1 year ago

I'm still having that problem. When used as a command line flag (i.e. .\Ferdium.exe --force-color-profile=srbg) Ferdium doesn't seem to completely load. Other command line flags cause a similar problem for me.

SpecialAro commented 1 year ago

I'm still having that problem. When used as a command line flag (i.e. .\Ferdium.exe --force-color-profile=srbg) Ferdium doesn't seem to completely load. Other command line flags cause a similar problem for me.

This is due to how we handle deeplinks at the start of the app (this is not working properly)