search

ferdium / ferdium-app

All your services in one place, built by the community
https://ferdium.org
Apache License 2.0
2.93k stars 176 forks source link

Changelog Link opens in Ferdium and blocks it #1232

Closed francwalter closed 1 year ago

francwalter commented 1 year ago

Avoid duplicates

Ferdium Version

6.4.0-nightly.2

What Operating System are you using?

Windows

Operating System Version

Windows 10 (64-Bit) Version 22H2

What arch are you using?

x64

Last Known Working Ferdium version

Never hit that link before.

Expected Behavior

When I click the Link for Full Changelog under Settings > Release notes I expect that the changelog opens in my browser but not in Ferdium. And if it opens in Ferdium, I should be able of going back to my services. The Menu bar should not be disabled, especially when I have it not disabled. Keyboard Shortcuts should still work.

Actual Behavior

I open in Ferdium the Changelog under:

Settings > Release Notes > Full Changelog (Link)

and Ferdium opens in his whole window (fullscreen, I guess) the changelog on Github. Now I am trapped in that page, no Menubar anymore, no service, no Shortcut is working (e.g. Reload Ferdium), I have to Quit Ferdium and reopen Ferdium by SystemTray menu (in the Ferdium Window I cant, no menu anymore, only Github page).

Steps to reproduce

  1. Go to Ferdium Settings
  2. Open Release Notes
  3. Click the Github-Link under Full Changelog
  4. Try to use again Ferdiums Services etc.

Screenshots

grafik

This is the whole Ferdium Window after hitting the changelog link.

Additional information

I guess this is not only related to the Changelog Link, but I hadnt such behaviour before. Normally a extern Link should not open in Ferdium, maybe it is the only "buggy" link.

Arthur-Huan commented 1 year ago

To open links in Ferdium, or not to, that is the question. Whether 'tis better for the user to suffer The slings and arrows of unwanted webpages in-app, Or to have web links open externally in the browsers, And by doing so cause bugs: to freeze, to voice call No more; And to have unresponsive download links.

I can confirm the page also opens within Ferdium on my Linux v6.3.0 version. I usually set links to open within Ferdium, and use the context menu to open certain links in the browser. Though, this link doesn't have a context menu, perhaps because it's not in a webpage but the app itself. Yet, some other links in the Settings, like in the About Ferdium section, do open externally.

francwalter commented 1 year ago

The issue is not that it is opening in Ferdium, but that this is making Ferdium unusable.

Alphrag commented 1 year ago

Hi @francwalter well done for spotting that. We are using a listener to block these events from opening in Ferdium and to open in the usual browser as follows: https://github.com/ferdium/ferdium-app/blob/4bf2fe30c1f58fbd97670876b974f488a40218aa/src/components/settings/releaseNotes/ReleaseNotesDashboard.tsx#L57-L65 This was working at some point before, so it appears that something in electron has changed without us noticing which makes our handling of the click fail. @SpecialAro would you have the time to look into it at some point?

Alphrag commented 1 year ago

@FANMixco do you know of a previous version in which this was working and actually opening the links in the browser?

SpecialAro commented 1 year ago

Hey! 💪

I can try to make some time to look into it. I think this might be related to a PR that changed the default behaviour of links "target" attribute. I remember seeing something about it.

FANMixco commented 1 year ago

@FANMixco do you know of a previous version in which this was working and actually opening the links in the browser?

I don't know. I found it by accident when I was checking the changelog.