ferdium / ferdium-app

All your services in one place, built by the community
https://ferdium.org
Apache License 2.0
2.66k stars 164 forks source link

Microsoft Teams has twice notifications with one message #1675

Closed awilliansd closed 2 months ago

awilliansd commented 2 months ago

Your issue

Version: 6.7.2 Server: Ferdium Server Electron: 29.1.5 Chrome: 122.0.6261.130 Node.js: 20.9.0 Platform: Windows 11 Arch: x64 Git branch: release

I tried to look the code, but i didn't see any line that it has something about notifications.

rmeissn commented 2 months ago

This does not seem to be related to MS Teams only, as I can observe it with WhatsApp and RocketChat too. I'm getting notifications in the Gnome notification bar as two entries for one message. It should be only one entry. I don't know whether this is related to my recent update to Gnome 46 (from 44) or to a recent Ferdium update.

Version: 6.7.2 Server: No Server Electron: 29.1.5 Chrome: 122.0.6261.130 Node.js: 20.9.0 Platform: Linux 6.8 Arch: x64 Build date: Wed Mar 27 2024 15:09:46 GMT+0100 (Mitteleuropäische Normalzeit) Git SHA: ce7a8772 Git branch: release

awilliansd commented 2 months ago

I think that it is ferdium, because i use Windows SO

tulexx commented 2 months ago

I only have MS Teams service which generates notifications, so I don't know about others. But what I noticed is that not only they are double, but also require a mouse click to disappear.

I had to resort to creating a custom recipe from the official one and adding onNotify which sets notification.options.requireInteraction to false and compares title and body with a previous one. If they're the same, I return null.

Version: 6.7.3 Server: No Server Electron: 30.0.1 Chrome: 124.0.6367.60 Node.js: 20.11.1 Platform: Linux 5.15 Arch: x64 Build date: Thu Apr 25 2024 03:13:04 GMT+0200 (Central European Summer Time) Git SHA: d8f519a8 Git branch: release

awilliansd commented 2 months ago

Where could I change this value??

ponces commented 2 months ago

I only have MS Teams service which generates notifications, so I don't know about others. But what I noticed is that not only they are double, but also require a mouse click to disappear.

I had to resort to creating a custom recipe from the official one and adding onNotify which sets notification.options.requireInteraction to false and compares title and body with a previous one. If they're the same, I return null.

Version: 6.7.3 Server: No Server Electron: 30.0.1 Chrome: 124.0.6367.60 Node.js: 20.11.1 Platform: Linux 5.15 Arch: x64 Build date: Thu Apr 25 2024 03:13:04 GMT+0200 (Central European Summer Time) Git SHA: d8f519a Git branch: release

Could you please share it?

tulexx commented 2 months ago

Sure. This is the webview.js.

I used this documentation to find the recipe folder, created a dev subfolder there and copied the whole msteams folder into it and changed the webview.js. After restarting Ferdium, this new service is available under Custom Services.

awilliansd commented 2 months ago

Thank you guy

ponces commented 2 months ago

Why is this closed? Was the main recipe changed?