Closed mcmxcdev closed 2 months ago
@mcmxcdev - I would suggest that we completely remove the .vscode
folder and add it to the .gitignore
file.
As a contributor, in the future, I would not want the .latestNewFangledEditorConfig
to show up and disrupt my local setup with something that a new person committed from their choice of editor.
As a common baseline, imo, that's what we have the editor config file which is supposed to be a defacto standard for.
@mcmxcdev - I would suggest that we completely remove the
.vscode
folder and add it to the.gitignore
file.As a contributor, in the future, I would not want the
.latestNewFangledEditorConfig
to show up and disrupt my local setup with something that a new person committed from their choice of editor. As a common baseline, imo, that's what we have the editor config file which is supposed to be a defacto standard for.
Okay sounds good to me, removed the folder completely in 141251d
(#1682)
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
@adonisjs/auth
,@adonisjs/session
and@emotion/react
dependencieslaunch.json
andtasks.json
Motivation and Context
Fixup improvement possibilities that I came across
Screenshots
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes