Additionally, will be good to allow paste url of icon, additionally to current ability to upload the icon from local filesystem, because most of favicons are available via url, so we'll can get rid of the "File » Save as + Upload to Ferdium" ritual :)
This is NOT included in this PR.
This PR makes use of the Google API for favicons (https://www.google.com/s2/favicons as stated in src/helpers/favicon-helpers.ts) - let me know if there is any issue on using this.
Screenshots
Without favicon
With favicon
Checklist
[x] My pull request is properly named
[x] The changes respect the code style of the project (pnpm prepare-code)
[x] pnpm test passes
[x] I tested/previewed my changes locally
Release Notes
Added ability to use favicons instead of default/custom icons (on edit service menu)
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Add ability to use favicons instead of default/custom icons
Motivation and Context
This fixes https://github.com/ferdium/ferdium-app/issues/1340 and fixes https://github.com/ferdium/ferdium-app/issues/257.
Issue https://github.com/ferdium/ferdium-app/issues/257 also refers:
This is NOT included in this PR.
This PR makes use of the Google API for favicons (
https://www.google.com/s2/faviconsas stated insrc/helpers/favicon-helpers.ts) - let me know if there is any issue on using this.Screenshots
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes
Added ability to use favicons instead of default/custom icons (on edit service menu)