ferdium / ferdium-app

All your services in one place, built by the community
https://ferdium.org
Apache License 2.0
2.86k stars 173 forks source link

Update Development environment setup instruction - for Python Dependency #706

Open karthikeyan-r opened 1 year ago

karthikeyan-r commented 1 year ago

Your issue

I am getting following error while trying to run build script locally for setting up development environment.

"CLEAN=true ./scripts/build-unix.sh"

Building app

ferdium@6.2.1-nightly.19 build preval-build-info-cli && gulp build && electron-builder --x64 --mac --dir

[00:10:26] Requiring external module @babel/register fs.js:47 } = primordials;

Even though node, npm & pnpm version is same as mentioned in instruction.

Laptop has Python 2 in it & installing Python3 and making it default resolved this error. So, please update python dependency in Setup document

karthikeyan-r commented 1 year ago

@vraravam Please assign this to me. I will update contribution document with python dependency details.

SpecialAro commented 1 year ago

@karthikeyan-r thank you for reporting this issue. Also, if this is a requirement (Python 3) we should not only point that out on the docs but also update the build scripts accordingly to test if the user has it or not.

Would you be able to do that too? 😁

karthikeyan-r commented 1 year ago

Sure, @SpecialAro. I will add validation in script as well.

vraravam commented 1 year ago

@karthikeyan-r - were you able to work on this? If not, should we unassign it from you so that some other contributor can act on it?