search

ferdium / ferdium-server

The server component that can either be self-hosted or hosted for general purpose - for use with the ferdium thick client.
MIT License
178 stars 43 forks source link

Add a linux/arm64 architecture variant to the official container #46

Closed lnhrdt closed 2 years ago

lnhrdt commented 2 years ago

Fixes ferdium/ferdium-server#45

lnhrdt commented 2 years ago

I believe this change will work because the base image (node:16.15.1-alpine) supports linux/arm64 but I have not actually tested this change myself (it would be difficult without project access).

CC: @Gibby & @SpecialAro because I saw in the git history you've both contributed to this workflow.

Gibby commented 2 years ago

Yep it should, I actually had more listed but decided to just do 1 when I did the initial commit and let PR's like this come in as needed.

cino commented 2 years ago

@lnhrdt Thanks for taking the time to create this pull-request!

@ferdium/reviewers I would like to add, that if build time is an issue when building for 2 platforms we can consider running a separate job for each platform parallel.

lnhrdt commented 2 years ago

Anyone get a chance to review this yet? Anything I can do to help?

SpecialAro commented 2 years ago

Hello @lnhrdt I'm sorry I didn't review this previously... I think this got lost in my notifications.

LGTM, will approve and merge 😄 Thank you for you contribution!