search

ferdium / ferdium-server

The server component that can either be self-hosted or hosted for general purpose - for use with the ferdium thick client.
MIT License
163 stars 41 forks source link

Remove python references and MSVS #94

Closed SpecialAro closed 7 months ago

SpecialAro commented 7 months ago

This PR fixes the build process for the ferdium-server.

I think that python and MSVS are not needed to build the project, therefore I deleted it. But it would be great if anyone test this out!

Thank you!

vraravam commented 7 months ago

please also search the whole codebase for other occurrences of "python" (there are lots) which need to be cleaned up

SpecialAro commented 7 months ago

According to https://github.com/ferdium/ferdium-server/blob/main/Dockerfile#L24-L25 - python is needed if running with sqlite...

Yes, I commented out that line after the adonis migration. I think that is not needed now 😄

please also search the whole codebase for other occurrences of "python" (there are lots) which need to be cleaned up

On it!

SpecialAro commented 7 months ago

Seems like python is, indeed, necessary!

mcmxcdev commented 7 months ago

Seems like python is, indeed, necessary!

Why is it necessary exactly? CI seems to pass, so some runtime failing?

SpecialAro commented 7 months ago

Seems like python is, indeed, necessary!

Why is it necessary exactly? CI seems to pass, so some runtime failing?

to build locally it might be necessary. CI is running in a containerized env that probably has python by default (not sure).

But then again, I havent tested without python

mcmxcdev commented 7 months ago

to build locally it might be necessary. CI is running in a containerized env that probably has python by default (not sure).

But then again, I havent tested without python

Could we assume then that devs have python installed? We could mention it somewhere rather than enforcing it and get rid of lots of code.

vraravam commented 7 months ago

Could we assume then that devs have python installed? We could mention it somewhere rather than enforcing it and get rid of lots of code.

I for one do not install python on my machine (I am a ruby-ist). So, assuming a system dependency doesn't make sense to me. Also, I am not sure whether python (any version) is present in all OSes by default.

mcmxcdev commented 7 months ago

Anything this PR is waiting on or is it ready to merge?

vraravam commented 7 months ago

If we remove the restriction of the specific MSVS version, can there be situations where someone tries to build on an older version of Windows (with an older version of MSVS) and thus cause breakages and support tickets?

SpecialAro commented 7 months ago

MSVS is not needed to build Ferdium server (only the Ferdium app). So no breakages will occur 😁