Closed AaronCheung430 closed 2 years ago
Just updated with commit. Hi guys, sorry, I am new to open source. I am not sure whether I am doing things right, as I am trying out features. Am I supposed to submit another review, like this one after I committed? or a comment? or what will usually be the case? Do I need to resolve those conversation above as well? Thank you
Once anyone interacts with an open PR, they keep getting notified for new updates (like how I got an email notification). So, maintainers will usually come back (uppon notification) to re-review the new changes. You are all good from that point of view.
Marking the issue as resolved - I usually leave it upto the person who raised it in the first place - so that they are satisfied with the latest state. So, please do not mark for resolution (unless you created that comment in the first place :))
@all-contributors please add @AaronCheung430 for documentation
@vraravam
I've put up a pull request to add @AaronCheung430! :tada:
Hi there,
I have added this question to the FAQ in case someone else needed help with it when installing.
Thank you