[Suggestion] Change mailable from blade view to markdown

ferdousulhaque / laravel-otp-validate

Laravel package for OTP validation with built-in features like max retry and resend mechanism. Both OTP/Security Code over SMS or Email or AWS SNS of your choice with template user-defined.

71 stars 13 forks source link

[Suggestion] Change mailable from blade view to markdown #6

Closed JawadR1 closed 1 year ago

JawadR1 commented 2 years ago

The current view for email is a simple blade view but Laravel offers an optional markdown view as well.

The advantages of using markdown view over simple blade view are:

You can write the email in markdown syntax (duh)
You can use prebuilt mail components provided by Laravel

It's just one function update and I don't see any disadvantages to using it.

Love to hear your thoughts about this.

ferdousulhaque commented 2 years ago

Thanks, let me check it out.

alex-ng-wesoft commented 2 years ago

FWIW, I have a local change I'm willing to upstream that allows the class of the mailable to be specified. Anyone that wants Markdown can create a custom mailable class, while people who want to stick with the default views can just accept the default.

This also makes it much easier for users of the library to customise their e-mails without making changes to this library. Thoughts?

JawadR1 commented 2 years ago

Yeah, I think allowing users to specify their own mailable class is the better way.

ferdousulhaque commented 2 years ago

@alex-ng-wesoft can you give a pull request to me to review.