fered / ebookdroid

Automatically exported from code.google.com/p/ebookdroid
0 stars 0 forks source link

New manual cropping menu option doesn't seem to do anything #330

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open any PDF.
2. Disable automatic cropping if you have it enabled.
3. Select Manual dropping from the view menu.

What is the expected output?
A rectangular selection that can used to determine the cropping should appear 
on the screen.

What do you see instead?
Nothing.

What version of the product are you using?
1.5.3

On what operating system?
Android 4.1.2

What device are you using?
Nexus 7 tablet

Please provide any additional information below.
I was excited to see the new manual cropping feature in the update description, 
and read in the FAQ how it is supposed to be used but can't get anything to 
happen when I tap on it. This may be a bug or I may be missing something about 
how it is supposed to be used.

Original issue reported on code.google.com by omar.ant...@gmail.com on 12 Oct 2012 at 11:02

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Hi, the FAQ  is still at an early stage. But it seems you are not able to reach 
the area selection stage.

The steps are: open a book (yeah :-) ), summon the menu, choose More, then 
View..., choose Manual Crop: you will see the current page and a rectangular 
frame.

This is where nothing happens? Have you tried to select auto-crop before 
accessing the manual crop menu (you can have it set, it does not matter). This 
should give you a defualt area set at the automatically detected margins.

The remaining steps, which I add for completeness are: 
Adjust the frame and then double tap inside it. Choose the manual cropping 
option you need, for example Crop all pages.

Original comment by peltio on 13 Oct 2012 at 12:38

GoogleCodeExporter commented 8 years ago
Yes, nothing happens when I select the Manual cropping menu item: I don't see a 
selection rectangle anywhere on the screen. I've tried both with auto-cropping 
checked and unchecked.

Original comment by omar.ant...@gmail.com on 13 Oct 2012 at 12:57

GoogleCodeExporter commented 8 years ago
manual crop can be defined only in single page mode, however it works in all 
modes.

Original comment by Alexander.V.Kasatkin@gmail.com on 13 Oct 2012 at 12:49

GoogleCodeExporter commented 8 years ago
Oh, thanks! It never occurred to me change the viewing mode. I'd think that 
defining the crops probably should work in the scrolling modes too (it could 
take you to a single page view where you set the cropping and then back to the 
mode you were in), but at least the current behavior should be documented.

Original comment by omar.ant...@gmail.com on 13 Oct 2012 at 1:18

GoogleCodeExporter commented 8 years ago
It is now. :-)

Original comment by peltio on 14 Oct 2012 at 5:28

GoogleCodeExporter commented 8 years ago
Fixed in trunk by adding warning message.

Original comment by Andrei.K...@gmail.com on 15 Oct 2012 at 7:55

GoogleCodeExporter commented 8 years ago
Issue 332 has been merged into this issue.

Original comment by Andrei.K...@gmail.com on 15 Oct 2012 at 7:57