search

fergaldoyle / angular.js-ie8-builds

AngularJS 1.3 builds for IE8
171 stars 39 forks source link

es5-sham is also required #31

Open Kidlike opened 8 years ago

Kidlike commented 8 years ago

Specifically Object.create.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create

Supported since IE9.

elantion commented 8 years ago

Yes, it need. I think we should update redme.md.

elantion commented 8 years ago

Sorry, update. You don't need to use es5-sham. Fergaldoyle have added polyfill already and comment ' es5-sham version doesn't work in this instance'.

I have fork this repo and make some progress, it seem like working perfect for now. https://github.com/elantion/angular.js-ie8-builds

Kidlike commented 8 years ago

OK. Fair point.

I actually discovered this when I was trying our app in Firefox 3.6.28 (don't ask why, just kill me now...)

So, based on the mdn docs, Firefox introduced Object.create in version 4.0.

The question then becomes: why doesn't Fergaldoyle's polyfill work for Firefox 3.6.28, but es5-sham does ?

fergaldoyle commented 8 years ago

The polyfils target IE8 only so that they can be aggressively applied and override any other shims which may not work as expected, e.g. es5-sham.

I doubt angular itself supports Firefox 3 so this build won't either, it's 2016!

Kidlike commented 8 years ago

It doesn't support ie8 either, but yeah I didn't have any expectations of support.... It's a technical discussion. If you wanna close this for not supported it's fine by me.

georules commented 8 years ago

I actually discovered this when I was trying our app in Firefox 3.6.28 (don't ask why, just kill me now...)

I think anyone looking at this repo seriously as a solution for their app shares your frustration. We should start a support group w/ weekly meetings.

elantion commented 8 years ago

My project is required to support IE8, so I have to make a polyfill for angular 1.4. I copy some code from fergaldoyle's repo. It's working good now. https://github.com/elantion/angular-polyfill @georules You can make another polyfill too. It's much easier than you think.

worthy7 commented 6 years ago

@elantion's solution fixed most of my problems. For some reason es5-shim was seriously breaking things for me, so I excluded it.