Trying to update search-index version to newest

[eklem]

Updating to newest version of search-index and adding tests for all versions of Node.js still supported.

This one will fail, but good to have a pull request to have a discussion.

Here's the test that fails:

# should get latest snapshot and import in into a new norch
not ok 284 Error: socket hang up
  ---
    operator: error
    expected: |-
      undefined
    actual: |-
      { [Error: socket hang up] code: 'ECONNRESET' }
    at: Request.<anonymous> (/Users/eklem/github_modules/norch/test/test.js:160:9)
    stack: |-
      Error: socket hang up
          at createHangUpError (_http_client.js:331:15)
          at Socket.socketOnEnd (_http_client.js:423:23)
          at emitNone (events.js:111:20)
          at Socket.emit (events.js:208:7)
          at endReadableNT (_stream_readable.js:1055:12)
          at _combinedTickCallback (internal/process/next_tick.js:138:11)
          at process._tickDomainCallback (internal/process/next_tick.js:218:9)
  ...

This error was introduced with version 0.12.0 of search-index where the add interface became streamy.

[eklem]

So the /snapshot endpoint seems to not work as intended anymore?

[fergiemcdowall]

Hmmm- will investigate...

-- Apologies for brevity- this message was sent from my mobile

On 24 Feb 2018, at 14:35, Espen Klem notifications@github.com wrote:

So the /snapshot endpoint seems to not work as intended anymore?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[eklem]

It's a bit to much unknown teritory for me to figure out on my own, but let me know if you want me to test different things.

[fergiemcdowall]

Will do

[eklem]

Actually, it seems it's the /latestSnapshot that is not working (if the /snapshot test is good enough).

[fergiemcdowall]

Ahh- in that case TODO: make a test for /latestSnapshot