search

ferguras / twitter-analysis

Scrape the Twitter Frontend API without authentication.
MIT License
25 stars 4 forks source link

Fix number of tweets received #6

Closed briwa closed 5 years ago

briwa commented 5 years ago

Hello, apparently when retrieving tweets, it doesn't really get the number of tweets you wanted. Example:

get_tweets('KingJames', tweets=5) # this will get you 14 tweets instead
get_tweets('KingJames', tweets=100) # this will get you 114 tweets instead

So this PR should fix it, with a slightly changed behavior for the default tweets from 100 to the number of tweets in the JSON (through new_latent_count). Also, fixed a minor issue with spacing of the mentions.

What do you think? Let me know.

Thanks.

ferguras commented 5 years ago

Thanks for the improvements. I will aprove it.

To be able to review changes, it would be really helpfull if you put in a pull request for each item separately. In this case one for the mentions, one for the default value and one for the number of tweets. When something is wrong, it would also impact only one change and not all.

briwa commented 5 years ago

@ferguras Alright, will keep that in mind. Thanks!