search

fergusean / nusoap

NuSOAP re-packaged for Packagist/Composer
http://sourceforge.net/projects/nusoap/
GNU Lesser General Public License v2.1
23 stars 72 forks source link

Fixing bug with _transient gobal variable #6

Open seismicmike opened 8 years ago

seismicmike commented 8 years ago

Hi!

I've been using your nusoap package from Packagist for a while now and it's worked pretty well for me. Today, I came across a weird issue. I was getting an error about an undefined index "_transient". I googled and came up with http://stackoverflow.com/questions/14607718/multiple-nusoap-clients-causes-undefined-index-transient-error

Apparently somebody called Scardetto had already patched this in their fork of nusoap but rather than trying to somehow trace that back to something that I could use with composer, I just decided to fork and patch your code.

So anyway, I figured I'd send this back upstream in case you're intreested. Here's the patch. You can pretty much ignore the changes to .gitignore, README, composer.json, etc.The material change is in lib/class.nusoap_base.php

Let me know if you have any questions. Thanks

williamorazi commented 8 years ago

I've been coming across this error when using PHPUnit with the backupGlobals configuration value set to TRUE. Disabling this configuration setting resolves the error being generated. Not sure why this isn't simply a static property to avoid this issue.

seismicmike commented 8 years ago

Interesting. I don't recall having any problems with this outside the PHPUnit context, so that's probably the culprit. I'll test with that disabled sometime and see if it makes a difference.

Thanks for the feedback!