search

fergusstrange / embedded-postgres

Run a real Postgres database locally on Linux, OSX or Windows as part of another Go application or test
MIT License
856 stars 89 forks source link

⭐️ use amd64 postgres on arm64 macOS #26

Closed chris-rock closed 3 years ago

chris-rock commented 3 years ago

I am unsure, I tested this locally. I think it will be tricky until github has proper support for arm macs. https://github.com/actions/runner/issues/805

fergusstrange commented 3 years ago

Yeah okay fair enough. I think I'll rework defaultVersionStrategy in order to pass in the os and arch in the future. At this point we can add coverage for this behaviour.

I'll merge and if you fancy tackling the above to make this block a little more testable please feel free to open another PR.

Great work!

chris-rock commented 3 years ago

I think the intuitive behavior is to allow users to override the version strategy. This would allow this lib to focus on the core features and leave users the option to override if necessary

fergusstrange commented 3 years ago

@chris-rock I'll add you to review the next pull request around the suggested changes then if you're interested?

In the meantime I've published a release for your changes.

chris-rock commented 3 years ago

@fergusstrange thank you very much! Yeah, I am happy to help.