feristhia / xmla4js

Automatically exported from code.google.com/p/xmla4js
0 stars 0 forks source link

IE9 Causes problems due to IE9 supporting getElementsByTagNameNS but not #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run the yui-chart-wizard in IE9
2. Set up the url and click the Discover Datasources button

I Expect the Data Source combo to be populated - instead there is a java script 
error:
Line: 151
Error: Object doesn't support property or method 'getElementsByTagNameNS'

This is using IE9 on Windows7 64bit.

The actual problem is caused by the registration of the handler method for 
_getElementsByTagNameNS, when this is setup, it checks the existance of 
docEl.getElementsByTagNameNS - IE9 returns true but the node passed to the 
function is an IXMLDomDocument2 which doesn't support the 
getElementsByTagNameNS method (bloody IE!)

I have made a temporary fix by catching the error at line 151 and replacing the 
function if getElementByTagNameNS doesn't exist - then continuing the call.  
Diff file attached.

Original issue reported on code.google.com by george.n...@gmail.com on 11 Apr 2012 at 4:04

Attachments:

GoogleCodeExporter commented 9 years ago
George, 

thanks!

I'll check out your patch, and I'll probably apply it. Thanks so far, it's 
great to get these kinds of contributions :)

Original comment by roland.bouman on 11 Apr 2012 at 4:57

GoogleCodeExporter commented 9 years ago
no problem. Great to have a library like this!

Original comment by george.n...@gmail.com on 14 Apr 2012 at 10:31

GoogleCodeExporter commented 9 years ago
Hi Georg,

it took some time, but I finally incorporated your changes in r137. Thanks for 
your contribution! It's noted in the commit log 
(http://code.google.com/p/xmla4js/source/detail?r=137)

Original comment by roland.bouman on 18 May 2012 at 9:08