Sub-specialization of status as exception classes - Githubissues

fermi-ad / acsys-python

Python module to access the Fermilab Control System

MIT License

8 stars 4 forks source link

Sub-specialization of status as exception classes #46

Closed julianbadillo closed 2 years ago

julianbadillo commented 2 years ago

To address #45

Created a sub-class per failing status.
Created an IntEnum inside status for code values.
Added a create(val) factory method for instantiating a Status.
Fixed except clauses and references to old ACNET_XX globals.

Some concerns:

I had to change ACNET_SUCCESS = 1 + 256 * 0 to ACNET_SUCCESS = 0 - otherwise I get ValueError: Invalid ACNET Status code: 0 -> Resolved by validating code 0.
When testing I get ConnectionRefusedError: [Errno 10061] Connect call failed ('131.225.135.139', 6808) -> Resolved by typing the correct port, addressed in #44

julianbadillo commented 2 years ago

Can we merge this? I think we'll need to tag a new version, but I don't know how.