search

fermi-lat / Fermitools-conda

Conda recipe files for the Fermi Sciencetools software analysis package: Fermitools
https://fermi.gsfc.nasa.gov/ssc/data/analysis/
BSD 3-Clause "New" or "Revised" License
34 stars 16 forks source link

hardcoded: export condaname="fermitools" in activate.sh #163

Open mireianievas opened 2 months ago

mireianievas commented 2 months ago

I just noticed there is a hardcoded line

export condaname="fermitools"

in the activate.sh

If you create the environment with a different name, it will fail to activate the conda environment.

donhorner commented 2 months ago

How are you creating your environment? I don't have any problems creating conda Fermitools environments with different names, and we've never had a report from a user with that problem.

The condaname in the activate.sh file just sets a directory name. I assume it's based on the installed conda package name(fermitools for Fermitools). The environment name is in $CONDA_PREFIX, so activate.sh sets paths like: export INST_DIR=$CONDA_PREFIX/share/${condaname} which in my current conda environment ("fermi220") is: ~/miniconda3/envs/fermi220/share/fermitools