search

fermitools / declad

BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

field fixes for declad 2.0.3 based on testing at CERN #13

Closed StevenCTimm closed 7 months ago

StevenCTimm commented 7 months ago

Fixed following issues:

incorrect formula for calculating sam run/subrun from metacat run/subrun incorrect factor for dune run/subrun Added headers to dune.py to import custom.metadfata_converter

added a "return out" in the dune.py after the mc.convert_all_mc_sam(metadata)

fixed typo isisnstance -> is instance

made return metadata["runs"][0][2] conditional on metadata type ( only for sam) fixed the field to fetch for run_type in convert_runs_mc_sam Made it calculate the subrun from runs_subruns list rather than runs list

fixed conversion first_event_number (mc) to first_event (sam). same for last_event

Did not pass the run_type through to SAM except as part of the runs triplet.

StevenCTimm commented 7 months ago

There's one other bug I have found that it is always writing to dataset 0 working on that now.

StevenCTimm commented 7 months ago

meta["run_number"] = rl[0] // 100000

don't need to divide the run number in core.runs by 100000 it is good the way it is.. have modified that and also one or two places that were looking for core.type instead of core.run_type as they should be.

now that is working, will again update the print statements and update this PR

StevenCTimm commented 7 months ago

ok that commit above is there too now.. declad running in production at CERN.. please comment on the PR.