search

fermitools / jobsub_lite

jobsub_lite is a wrapper for HTCondor job submission
Apache License 2.0
1 stars 7 forks source link

Discuss experiment-specific code appearing in jobsub_lite #288

Open shreyb opened 1 year ago

shreyb commented 1 year ago

In reviewing #284, I realized that we have experiment-specific setup code/options in our general ArgumentParser. Ideally, for jobsub_lite, experiment-specific code should be in experiments' scripts, not jobsub_lite. This is a work item to discuss with Minerva if they really need us to keep that in jobsub_lite. If they do need it to stay here, we can keep it, and eventually deprecate it. In that case, we should move it out of the get_parser function and have it be its own function for code-organization purposes.

marcmengel commented 1 year ago

The only actually experiment specific flag here is --cmtconfig. -i -t and -r all actually do something in the generic case: you can jobsub_submit -i '/cvmfs/dune.opensciencegrid.org/products/dune/setup_dune.sh ' -r 'v0_9_41_00_02 -q c7:prof' and it will source their setup script and setup that version of dunetpc...

There are still experiment specific setup blocks in the wrapper template for older experiments (minos, nova and minerva) for backwards compatability; I'm pretty sure we declared that "legacy" and that we aren't adding any new ones even in old jobsub.