search

fermitools / managed-tokens

Managed Tokens service for FIFE Experiments at Fermilab
Apache License 2.0
0 stars 0 forks source link

Clean up CommandEnvironment interface #4

Closed shreyb closed 1 year ago

shreyb commented 1 year ago

" Maybe clean up CommandEnvironment so that it has a friendlier interface. We can just have the actual env var name be internal to the type, rather than the user needing to know that. I.e. You would say c := CommandEnvironment{Krb5ccname: "blahblah"}, and not need to specify Krb5ccname: "KRB5CCNAME=blahblah""

https://github.com/shreyb/managed-tokens/blob/eadd9acacb91350cd52bb8741367a83e7c33caaa/internal/environment/commandEnvironment.go#L7

shreyb commented 1 year ago

Note: This will probably result in a merging of *CommandEnvironment.ToMap and *CommandEnvironment.ToValues.

shreyb commented 1 year ago

Did this while working on #2.