enhancement(animation): dont animate translate while dragging

fermoya / SwiftUIPager

Native Pager in SwiftUI

MIT License

1.29k stars 172 forks source link

enhancement(animation): dont animate translate while dragging #188

Closed nylki closed 3 years ago

nylki commented 3 years ago

This is the continuation from the previous PR (https://github.com/fermoya/SwiftUIPager/pull/187) to target https://github.com/fermoya/SwiftUIPager/issues/157.

This change removes the withAnimation from the onDragChanged handler to directly translate drag positions instead of animating them. Please note: Indentation makes the diff appear bigger than there is actual change.

fermoya commented 3 years ago

Thanks @nylki

fermoya commented 3 years ago

You're LIVE. See version 2.0.2

fermoya commented 3 years ago

Unfortunately, I'm gonna have to revert these changes. They're introducing a bug #193