[BUG] bounces boolean appears to be inverted

fermoya / SwiftUIPager

Native Pager in SwiftUI

MIT License

1.27k stars 166 forks source link

[BUG] bounces boolean appears to be inverted #291

Open danielkramer opened 2 years ago

danielkramer commented 2 years ago

Describe the bug Settings .bounces(false) appears to cause bouncing.. while setting to true seems to eliminate them.. I think your bool is flipped

To Reproduce

Steps to reproduce the behavior
Sample code

Expected behavior I'd expect it to be the other way around

Screenshots / Videos If applicable, add screenshots to help explain your problem.

Environment: iPhone 12 Pro

Additional context Add any other context about the problem here.

danielkramer commented 2 years ago

Hmm.. maybe I'm wrong. I'm seeing bounces either way. But I do see if I half pull a page and let go it bounces with it true where it does not false.. so maybe I'm wrong. Sometimes I still get bounces with false and I think it's cause by the next page not being loaded yet, or it's bogged down loading some future page. Each page is a hi-res image so depending on network load it may be slow and that I think causes bounces