search

fermyon / cloud-plugin

A Spin plugin for the Spin CLI for managing Spin apps in Fermyon Cloud.
https://developer.fermyon.com/cloud/
Apache License 2.0
8 stars 13 forks source link

chore(Cargo.toml): bump spin crates #102

Closed vdice closed 1 year ago

vdice commented 1 year ago

Bumps to current HEAD commit of Spin, particularly to get https://github.com/fermyon/spin/commit/d041cc0470c39a341de7b709e7cab5e7d5a011ef

Closes https://github.com/fermyon/cloud-plugin/issues/101

itowlson commented 1 year ago

This makes me wonder if we should be flagging the change to folks like the containerd shim maintainers.

vdice commented 1 year ago

This makes me wonder if we should be flagging the change to folks like the containerd shim maintainers.

Ah, in case example or template apps are used from main/canary with the 1.5.0-based shim? If that is a likely possibility, we might consider changing the example and template apps back (eg re-adding the base config) until after the shim updates to the next Spin release...

itowlson commented 1 year ago

The templates still have base (at least for now) so there's a good chance they won't come across it. But yes, generally, because it's plausible that people will try to run 1.6 apps on k8s and get a surprising error.

I wonder if in future we should consider minor versions of the manifest format for stuff like this - at least then a host could say "hey you need to update me" rather than "missing required element."

vdice commented 1 year ago

I wonder if in future we should consider minor versions of the manifest format for stuff like this - at least then a host could say "hey you need to update me" rather than "missing required element."

That seems like a good idea to me.