feat(deploy.rs): insert cloud plugin version into locked app metadata

fermyon / cloud-plugin

A Spin plugin for the Spin CLI for managing Spin apps in Fermyon Cloud.

https://developer.fermyon.com/cloud/

Apache License 2.0

8 stars 13 forks source link

feat(deploy.rs): insert cloud plugin version into locked app metadata #147

Closed vdice closed 1 year ago

itowlson commented 1 year ago

I guess I am also a bit concerned about unconditionally sticking this into the lockfile because it means that what gets deployed to the cloud is not what the user has in their registry. I know we do it for the HTTP base but that was just a patch until Cloud could handle baseless apps; this seems like a forever thing. Maybe in future we'll be able to put it out of band somewhere. Or maybe I'm being too precious about preserving identity. I wish we had longer to think about this though.

itowlson commented 1 year ago

(that last comment is not a thing to worry about changing at this point, just me thinking out loud)

vdice commented 1 year ago

@itowlson: feedback addressed in https://github.com/fermyon/cloud-plugin/pull/147/commits/6398eee761904920d2eeaa15ff44ecf839a9fe63; merging.