fermyon / conformance-tests

A suite of conformance tests for Spin compliant runtimes
Apache License 2.0
1 stars 1 forks source link

Add a simple key-value test #7

Closed rylev closed 3 months ago

rylev commented 3 months ago

Before we merge this, there's one open question:

The test has an assumption that a key-value store labeled "default" exists. In Spin CLI, this is the case without any further action, but for other runtimes, there might not be a "default" key-value store by default, and the test runner might need to take action to create the store.

We'll need to figure out some mechanism for the test to specify that it is relying on the store existing.

lann commented 3 months ago

We'll need to figure out some mechanism for the test to specify that it is relying on the store existing.

Would it make sense to have some kind of explicit "precondition" asserts that document this kind of requirement?

rylev commented 3 months ago

Would it make sense to have some kind of explicit "precondition" asserts that document this kind of requirement?

Yes, I'm going to try to come up with something like this. We'll likely have to change it over time, but hopefully we'll eventually land on something that works.

rylev commented 3 months ago

Ok I've changed the "services" config to a general "preconditions" config which covers both the services that need to run as well as other preconditions (e.g., which stores need to exist).