Closed garikAsplund closed 4 months ago
@garikAsplund Are the CR characters on lines you've changed? Normally git takes care of this stuff - if you're on Windows and have autocrlf turned on then it shouldn't be an issue - and if you're on Linux or Mac then I'm not sure where they'd have come from!
I'm on a Mac and was confused by it too! Hope it gets sorted out.
Huh. I see three matches for the grep and they are all "M at the beginning of a line".
@tpmccallum any idea what's going on with that check?
@karthik2804 does Bartholomew really still get mad about CRs? could we fix it at source and make this check go away?
@itowlson I am not sure if Bartholomew gets mad about CRs but if that is the case, we can take a leaf out of this PR and just make the CRs vanish (i.e) doc.replace{"\r", ""}
which would cover both cases.
Hi @garikAsplund
Thanks for this contribution.
A few updates:
It looks like the cat -ve <filename> | grep '^M' | wc -l
is actually matching on lines that start with upper-case M
. This is not an issue. Apologies for the confusion. I will adjust the template so this is not a roadblock for others.
I see you have tried really hard to incorporate the no copy in the example. This is a tough task. Perhaps an image will do the trick. Please see how the latest commit to this PR adds an image and resolves this meta issue.
I am happy with this PR now. Just touching in with you to see if you agree. Thanks again for catching this and creating the PR. Really appreciate your contribution.
The ol' extra backtick trick
I think the example for
<!-- @nocpy -->
was off before--it had a copy block! Also there was a link that was kinda botched so fixed that.When I run
cat -ve <filename> | grep '^M' | wc -l
I get 2 😞Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title
,template
, anddate
are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep '^M' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors