Closed tpmccallum closed 4 months ago
Had to add the package lock json files back, sorry. The build failed without new versions of them as part of this pr. Not entirely sure if we can add them both the the .gitignore file or if this will cause future problems.
We shouldn't gitignore them. I guess this is just a random wonder of NPM,
@itowlson it is an artifact of npm install
instead of npm ci
. npm insatll
does not respect the lockfile and upgrades dependencies as long as they satisfy the requirements in package.json
. npm ci
on the other hand respects the lockfile.
Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:
title
,template
, anddate
are all settemplates/*.hbs
files) that points to a document.md
that is set to publish in the future? If so please only publish the.md
and.hbs
changes in real-time (otherwise there will be a menu item pointing to a.md
file that does not exist)cat -ve <filename> | grep $'\r' | wc -l
and expect 0 as a result)bart check
PREVIEW_MODE=1
and runnpm run styles
to update styling)npm run test
and resolved all errors