fermyon / developer

This is the home for developer.fermyon.com
https://developer.fermyon.com
Apache License 2.0
51 stars 66 forks source link

Updating spin test page and including second example in the process #1279

Closed tpmccallum closed 4 months ago

tpmccallum commented 4 months ago

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

tpmccallum commented 4 months ago

Had to add the package lock json files back, sorry. The build failed without new versions of them as part of this pr. Not entirely sure if we can add them both the the .gitignore file or if this will cause future problems.

itowlson commented 4 months ago

We shouldn't gitignore them. I guess this is just a random wonder of NPM,

karthik2804 commented 4 months ago

@itowlson it is an artifact of npm install instead of npm ci. npm insatll does not respect the lockfile and upgrades dependencies as long as they satisfy the requirements in package.json. npm ci on the other hand respects the lockfile.