fermyon / developer

This is the home for developer.fermyon.com
https://developer.fermyon.com
Apache License 2.0
51 stars 66 forks source link

Use npm ci instead of npm install #1283

Closed tpmccallum closed 4 months ago

tpmccallum commented 4 months ago

Signed-off-by: tpmccallum tim.mccallum@fermyon.com Content must go through a pre-merge checklist.

Fixes https://github.com/fermyon/developer/issues/922

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

github-actions[bot] commented 4 months ago

🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1283-g6atov7i.fermyon.app

tpmccallum commented 4 months ago

Also, as this PR I just checked that we can do the following and local preview:

$ cd spin-up-hub/
$ npm ci
$ cd ../
$ npm ci
$ spin build
$ spin up -e PREVIEW_MODE=1

All worked a treat!

Then when I went ahead and performed git add and git commit there were no redundant file, which is perfect.

$ git add .
$ git commit -S --signoff -m "Should not create files"
On branch tpmccallum-patch-43
Your branch is up to date with 'origin/tpmccallum-patch-43'.
nothing to commit, working tree clean