search

fermyon / developer

This is the home for developer.fermyon.com
https://developer.fermyon.com
Apache License 2.0
53 stars 69 forks source link

Developer Content Tweaks #1349

Closed flynnduism closed 2 months ago

flynnduism commented 3 months ago

This PR makes a couple of content updates and modifies the UI buttons to better promote Spin.

Homepage Content

Nav CTAs

dev-nav

These buttons have been focused on Cloud, regardless of what project docs you are viewing. And we should do a better job at encouraging more Spin ⭐ 's.

This PR will default the menu to show Spin actions (Star on Github, go to Quickstart) for the homepage and /spin sections. The Cloud login/signup buttons will still appear if you are looking at /cloud/ pages.

github-actions[bot] commented 3 months ago

🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1349-pdqj64ha.fermyon.app

karthik2804 commented 3 months ago

The star button seems to be stuck in dark mode on chrome and firefox for me image

flynnduism commented 3 months ago

The star button seems to be stuck in dark mode on chrome and firefox for me

Struggling to recreate this (Chrome, FIrefox). @karthik2804 could you delete cookies (saved theme pref) and re-test? 🥺

karthik2804 commented 3 months ago

@flynnduism I took at peek at the CSS, and it seems to be directly styling to the default system theme. The element has the following CSS applied to it which mean it switches based on my system preference instead of the theme. Possibly some !important will solve it 😅 image

flynnduism commented 2 months ago

@flynnduism I took at peek at the CSS, and it seems to be directly styling to the default system theme. The element has the following CSS applied to it which mean it switches based on my system preference instead of the theme. Possibly some !important will solve it 😅

GitHub Button Theme

light-dark-gh-brtn

Following up on this - the Github button theme is not easy to fix!

Screen Shot 2024-08-23 at 3 10 13 PM

!important doesn't cut it, and reinforcing with (prefers-color-scheme: light/dark) is not fixing it either. The button is rendered after the DOM, and is treated like an iframe (shadow root) - our local styles and overwrite attempts have no effect.

Note the OS > browser > user fermyon cookie theme inheritance behaves differently depending on what browser you use.

Blocking?

I'd suggest filing the button's CSS theme inheritance as an issue, and try and get these content updates out to the live site. What do you think @karthik2804

karthik2804 commented 2 months ago

It is definitely not blocking. Can be added as an issue.