fermyon / developer

This is the home for developer.fermyon.com
https://developer.fermyon.com
Apache License 2.0
53 stars 69 forks source link

Update variables documentation with latest APIs and better example #1356

Closed kate-goldenring closed 2 months ago

kate-goldenring commented 3 months ago

Our variables example showed a bad example of checking passwords -- it does not at minimum do a constant time comparison. While it is an example, we cannot assume that folks will not use it. Instead, this updates the example to be a more realistic one that calls an API with a token.

This also updates the examples to use the latest SDKs -- Python was out of date -- and talks about templating within the manifest.

I've run all examples locally -- here is a repo with the examples for if we need to test them for future sdk changes: https://github.com/kate-goldenring/spin-variables-examples

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

itowlson commented 3 months ago

I think all the CI failures are changes to the JS SDK reference which will get fixed via #1355

kate-goldenring commented 3 months ago

@itowlson this should be ready for another review