fermyon / hippo-openapi

OpenAPI clients and related artifacts for Hippo
Apache License 2.0
3 stars 3 forks source link

fix: remove Field wrapping of PatchChannelCommand arguments #10

Closed kate-goldenring closed 2 years ago

kate-goldenring commented 2 years ago

Currently, we are wrapping each PatchChannelCommand argument in an associated structure. This not only seems unnecessary but also causes empty contents to be sent to Hippo Web, as the command received by Hippo Web contains all null arguments except the ChannelId guid which is not field wrapped. This results in a null exception when Hippo Web reads the command.

Removing the wrapping causes requests to patch channels to succeed.

Associated changes are needed in hippo-cli client. Signed-off-by: Kate Goldenring kate.goldenring@fermyon.com