fermyon / homebrew-tap

Fermyon's Homebrew Tap
Apache License 2.0
2 stars 9 forks source link

13 bart formula #15

Closed dimitrilw closed 10 months ago

dimitrilw commented 10 months ago

Should fix #13 . Also uses a test routine that validates installed version number.

itowlson commented 10 months ago

@dimitrilw Could you sign the commits for DCO purposes please? You'll probably also need to GPG-sign them (I'm not sure about this repo but a lot of our repos require verified GPG-signed commits). Thanks!

dimitrilw commented 10 months ago

@dimitrilw Could you sign the commits for DCO purposes please? You'll probably also need to GPG-sign them (I'm not sure about this repo but a lot of our repos require verified GPG-signed commits). Thanks!

I'll get that set-up today.

dimitrilw commented 10 months ago

Thank you for advising me to add GPG verification. Done.

image
dimitrilw commented 10 months ago

I see that the DCO req is for every merged commit. The "Details" advises me to rebase & resubmit. Doing that now.

image

I apologize for the Github-noob error. I have not used this feature of Github before (as you can tell) and I'm learning as I go.

dimitrilw commented 10 months ago

Done.

dimitrilw commented 10 months ago

I see the fails & I'm working to fix. Thank you for being patient with me -- first Homebrew Formula submission, so it is a learning experience.

dimitrilw commented 10 months ago

Updated.

dimitrilw commented 10 months ago

Also re-updated GPG signature on last commit -- I apologize. I did not realize that I needed to enable git signatures & set as default behavior in:

Adding that note here in case it helps anybody else.

dimitrilw commented 10 months ago

Gah! I apologize. My VS-Code settings are adding that last LF when I commit & push. Manually fixing outside VS-Code. ...I hope I have entertained you all with these errors. 😊

dimitrilw commented 10 months ago

Of note: I do not understand the other fail on MacOS-13. It shows:

image
kate-goldenring commented 10 months ago

Thanks for all the iterations here @dimitrilw! Do you mind signing your latest commit? My assumption is that the macos workflow there was canceled because the ubuntu workflow errored but i have not dug into it

dimitrilw commented 10 months ago

gah! I thought I had git config'd to auto-sign when I did git commit from CLI. ......so many potholes on this road. 😄

dimitrilw commented 10 months ago

Done. Thank you for being patient with me.

itowlson commented 10 months ago

Thank you @dimitrilw for having the patience to keep at it despite all those potholes!

dimitrilw commented 10 months ago

and just closing loop on this:

image

🥳