search

fermyon / homebrew-tap

Fermyon's Homebrew Tap
Apache License 2.0
2 stars 9 forks source link

17 spin forumula test rebase #22

Closed dimitrilw closed 9 months ago

dimitrilw commented 9 months ago

for issue #18

dimitrilw commented 9 months ago

Re test-bot fail -- I ran it on my system (MacOS) and it was happy. 😂

image

So, looking at error to fix it & resubmit.

dimitrilw commented 9 months ago

newlines added to end of both spin.rb & bart.rb -- I must have something in my VS-Code configs that is stripping them when I push from within VS-Code. 🤷🏻 More little details for me to look for.

But good ol' terminal (vim & git-CLI) to the rescue! :)

dimitrilw commented 9 months ago

Oh! Wait... resubmitting. I see now that the version is already parameterized. I apologize. Fixing....

dimitrilw commented 9 months ago

@kate-goldenring , I believe it's good now. 😊

dimitrilw commented 9 months ago

Ok, I have to admit that the test-bot is confounding. It failed me because I did not have a trailing new-line. So I added them, and it passed. ...then I realized the version parameters were already in-place, so I edited to reflect that and kept the new-line in. Now it fails on the existence of a new-line. 🤦🏻 ......fixing. I think. We'll see if test-bot agrees.

dimitrilw commented 9 months ago

for ref, here's the fail message after commit 47bc4af ... I did not screenshot the previous pass (after adding newlines) or the previous fail (stating newlines needed to be added); not sure why test-bot hates contributors named Dimitri. 😄

image