local: Use an HTTP health check for Hippo

fermyon / installer

Fermyon Installer

https://fermyon.dev

Apache License 2.0

160 stars 39 forks source link

local: Use an HTTP health check for Hippo #50

Closed lann closed 2 years ago

lann commented 2 years ago

Signed-off-by: Lann Martin lann.martin@fermyon.com

lann commented 2 years ago

LGTM! One quick quirk about this endpoint: .NET returns a 200 with either "Healthy" or "Unhealthy" depending whether it can connect to nomad and bindle or not. Can the http probe somehow differentiate between the two?

It sure can't!

Is that something that could be changed in Hippo? Using status codes for health check results is a pretty strong convention...

bacongobbler commented 2 years ago

Oh yes! I've been wondering about replacing the default health check libs in .NET with something else for this exact reason. Thanks for the clarification.

lann commented 2 years ago

OK, we'll defer this change until that happens.

lann commented 2 years ago

https://github.com/deislabs/hippo/issues/889