search

fermyon / installer

Fermyon Installer
https://fermyon.dev
Apache License 2.0
158 stars 38 forks source link

feat(gcp): init gcp support #76

Closed FrankYang0529 closed 2 years ago

FrankYang0529 commented 2 years ago

Signed-off-by: Frank Yang yangpoan@gmail.com

FrankYang0529 commented 2 years ago

Hi @vdice, thanks for your quick review. I will fix it and try to put similar parts together tomorrow. 👍

vdice commented 2 years ago

@FrankYang0529 thanks for the updates! I'm back at my computer today after some time off and will review the updates ASAP.

FrankYang0529 commented 2 years ago

Thank you for the latest batch of updates. One last request: would it be possible to add an entry to the root-level README mentioning/linking to this GCP installer? Then we're ready to merge this in.

Hi @vdice, I add GCP to root-level README. Please help me take a look. Thank you.