search

fermyon / installer

Fermyon Installer
https://fermyon.dev
Apache License 2.0
160 stars 39 forks source link

GCP TF Provider Old as dirt #96

Open knee-berts opened 2 years ago

knee-berts commented 2 years ago

Howdie! The current google cloud tf provider is set to 3.5 and presents a challenge for users who are using ARM based Macs. Terraform cli took a minute to adopt go 1.16, which supports mac ARM, and that delay cascaded to the GCP provider. Updating the GCP provider to 4.31 will allow for ARM based mac support.

knee-berts commented 2 years ago

Happy to take this one. I've got it all running in my own test bed.

lann commented 2 years ago

@FrankYang0529 as the original author of the GCP work, any concerns here?

FrankYang0529 commented 2 years ago

Yeah, I think it's good to upgrade gcp terraform provider. Version 3.5 was released almost 2 years ago. It's good to update to the latest version. Version 4.31 works fine on my laptop.

knee-berts commented 2 years ago

Feel free to assign this to me. I have a PR ready to go.