search

fermyon / installer

Fermyon Installer
https://fermyon.dev
Apache License 2.0
158 stars 38 forks source link

Added an early exit for unsupported OS environments #99

Closed DougSchmidt-AI closed 2 years ago

DougSchmidt-AI commented 2 years ago

This is a first-time user experience improvement.

Since nomad, consul, and spin all have native Windows releases, running the installer from a Windows git bash environment (msys) sort of works, but the traefik job fails internally, without a clear reason in the console (other than "it took too long").

The source of the failure is buried in the nomad.log, since the traefik component download 404-ed because the windows release is a zip, not a tar.gz.

The added OS environment check at the start of the platform installer will point n00bs in the right direction.

vdice commented 2 years ago

@DougSchmidt-AI when convenient, can you sign the commit on this PR (https://docs.github.com/articles/about-gpg/)? Let me know if I can help. Thank you!

DougSchmidt-AI commented 2 years ago

@vdice Forgive the churn, I think I'll get the next signed commit right...

vdice commented 2 years ago

@DougSchmidt-AI no worries -- thank you for the extra effort here. I do see that the most recent commit is signed. Would it be possible to rebase and squash both commits into one, signed commit?

DougSchmidt-AI commented 2 years ago

@vdice There we go. Hopefully no more problems between keyboard and chair.

vdice commented 2 years ago

Much appreciated, thanks again @DougSchmidt-AI!