search

fermyon / leptos-spin

Template for server-side Leptos apps on Spin
32 stars 6 forks source link

Add ResponseOptions and runtime code to server functions, enable expe… #20

Closed benwis closed 10 months ago

benwis commented 10 months ago

This should close #13 and #14, although I am leaving open what to do about Request handling.

Would appreciate some help testing server fn custom headers and status

itowlson commented 10 months ago

Could you sign-off (and GPG-sign if not already) the commit please? Thanks!

benwis commented 10 months ago

Could you sign-off (and GPG-sign if not already) the commit please? Thanks!

Let's see if I can get arch linux to sign commits

benwis commented 10 months ago

So I've patched that, now we just need to test changing headers and status in server functions, and the use of the new experimental islands mode

itowlson commented 10 months ago

When you say "we need to test", are you saying we need to do that as part of this PR, or can I merge this?

benwis commented 10 months ago

It's mergable, by need to test I meant that it might be good to have a second person check it out. It's working on my end

On Wed, Jan 24, 2024, at 3:27 PM, itowlson wrote:

When you say "we need to test", are you saying we need to do that as part of this PR, or can I merge this?

— Reply to this email directly, view it on GitHub https://github.com/fermyon/leptos-spin/pull/20#issuecomment-1909091319, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBTCIXVVF4IMVGJTK4MQTYQGKFHAVCNFSM6AAAAABCJPQDWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZGA4TCMZRHE. You are receiving this because you authored the thread.Message ID: @.***>