search

fermyon / leptos-spin

Integration library for running server-side Leptos apps on Spin
31 stars 6 forks source link

Upgrade leptos-spin to support leptos 0.6 #23

Closed benwis closed 7 months ago

benwis commented 8 months ago

This is my draft PR to make leptos-spin compatible with leptos 0.6. Because we've reworked server functions, we now need a proc macro crate, so I've made this a workspace. Should address #16

This does not compile yet, I'm stuck on two issues

  1. I can't mutate status on a Request
  2. I can't figure out how to pass a stream to an OutgoingResponse or parse the body as a stream from IncomingRequest
benwis commented 8 months ago

@itowlson I've finished the changes for leptos 0.6, and believe they're ready for merging!

itowlson commented 7 months ago

Looks like there are a couple of conflicts too, hopefully easy ports from the file moves.

benwis commented 7 months ago

To be perfectly honest I did not test the template chances, they were done by @sjud and I've been working off the leptos template

benwis commented 7 months ago

@itowlson My github fu might be bad, but it won't show me what the conflicts are because I don't have write access to the repo

itowlson commented 7 months ago

Huh. It won't show me what the conflicts are either. "Too complex to resolve in the web editor" apparently.

image

Could you try doing a rebase locally?

Also, let me know if you'd like me to pick up the template chanmges - happy to send a PR.

benwis commented 7 months ago

Huh. It won't show me what the conflicts are either. "Too complex to resolve in the web editor" apparently.

image

Could you try doing a rebase locally?

Also, let me know if you'd like me to pick up the template chanmges - happy to send a PR.

Sure, I'd love you to handle those. I'll try rebasing against the origin repo