search

fermyon / leptos-spin

Integration library for running server-side Leptos apps on Spin
32 stars 6 forks source link

Leptos 0.7 upgrade #48

Open ogghead opened 3 weeks ago

ogghead commented 3 weeks ago

Hi all!

This will ideally address #44. ~Creating this draft of Leptos 0.7 upgrade with partial changes -- several functions in lib.rs are still not fully updated and so as of time of creation, this does not compile. Creating this in hopes of getting eyes from Leptos experts on whether this is the right path to follow to upgrade. Contributions to move this to completion are appreciated from anyone interested!~

Update 11/4: leptos_wasi now provides a universal foundation for running a Leptos back-end in Webassembly runtimes -- I have updated this PR with a draft template relying on that integration. Still need to update README with changes, but this is tentatively ready for use

Update 11/10: Updated README and retested -- everything is working as expected -- ready for feedback!

itowlson commented 1 week ago

@benwis I can't add you as a reviewer for some reason but it would be great if you could also take a look - thanks!

itowlson commented 1 week ago

Wow, leptos-wasi makes all this soooooooooo much simpler...!

itowlson commented 1 week ago

@ogghead Just had a query on Discord about this. Would you like this merged at stands with Leptos 7-rc1 (once Ben has looked and any required tweaks/tidying have been done), or were you envisaging waiting for Leptos 7 release? I am okay with either, just checking on how you feel.

ogghead commented 1 week ago

@ogghead Just had a query on Discord about this. Would you like this merged at stands with Leptos 7-rc1 (once Ben has looked and any required tweaks/tidying have been done), or were you envisaging waiting for Leptos 7 release? I am okay with either, just checking on how you feel.

Hey great timing 👋 thanks for reviewing! I think this is tentatively ready to merge barring any additional required tweaks/tidying. I am not sure exactly when the planned release date of Leptos 0.7 is but I would hope any additional changes needed would be minimal. So, merging with these dependencies and creating a quick follow-up PR to update versions + release a tagged version of the template once 0.7 is out makes sense to me!

ogghead commented 1 week ago

Ok, addressed PR feedback thus far, but please let me know if you have any other thoughts @itowlson! I very much appreciate your feedback on this :) @benwis hopefully this PR is up to snuff!

itowlson commented 11 hours ago

@benwis Sorry to badger, but do you know if you'll have bandwidth to look at this? No worries if not.

ogghead commented 5 hours ago

Thanks for the review @benwis and the bump @itowlson! I have responded to comments + pushed up changes to address. I will keep an eye out for additional feedback + discussion on open comments -- I appreciate the eyes on this PR!

benwis commented 3 hours ago

Thanks for the review @benwis and the bump @itowlson! I have responded to comments + pushed up changes to address. I will keep an eye out for additional feedback + discussion on open comments -- I appreciate the eyes on this PR!

Really nice work! Only one comment I see left, otherwise this should be good to merge

ogghead commented 3 hours ago

I appreciate the quick review and additional context @benwis! Updated to address that comment now